abh1sar commented on code in PR #8875:
URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1554533096
##########
engine/schema/src/main/java/com/cloud/storage/dao/VolumeDaoImpl.java:
##########
@@ -841,4 +866,13 @@ public List<VolumeVO> listByIds(List<Long> ids) {
sc.setParameters("idIN", ids.toArray());
return listBy(sc, null);
}
+
+ @Override
+ public List<VolumeVO> listByPoolIdVMStatesNotInCluster(long clusterId,
List<VirtualMachine.State> states, long poolId) {
+ SearchCriteria<VolumeVO> sc = volumePoolNotInClusterSearch.create();
+ sc.setParameters("poolId", poolId);
+ sc.setParameters("states", states);
Review Comment:
There was a bug here in the way I was using the conditionName.
Have fixed and tested. It seems to be working. Please look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
