weizhouapache commented on code in PR #8875:
URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1561803442
##########
plugins/storage/volume/datera/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/DateraPrimaryDataStoreLifeCycle.java:
##########
@@ -395,6 +395,15 @@ public void disableStoragePool(DataStore dataStore) {
dataStoreHelper.disable(dataStore);
}
+ @Override
+ public void changeStoragePoolScopeToZone(DataStore store, ClusterScope
clusterScope, HypervisorType hypervisorType) {
+ /*
+ * We need to attach all VMware, Xenserver and KVM hosts in the zone.
+ * So pass hypervisorTpe as null.
+ */
+ super.changeStoragePoolScopeToZone(store, clusterScope, null);
Review Comment:
> Feature is not tested and supported on Datera. But if a root admin wishes,
he can use it. We are not preventing any kind of storage from using this
feature. The feature will make the DB updates and connect/disconnect the hosts
to the storage pool as required. It is not ensured that it will work with
configurations other than NFS/Ceph, KVM/VMware and Default Primary storage
provider.
> Have mentioned this as a warning in UI and Api docs.
Fair enough
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
