hsato03 opened a new pull request, #8654: URL: https://github.com/apache/cloudstack/pull/8654
### Description Each hypervisor can support a different number of network adapters. Comparing KVM and VMWare, VMWare defines a limited number of NICs for each ESXi machine (https://configmax.esp.vmware.com/guest?vmwareproduct=vSphere&release=vSphere%207.0&categories=1-0), while the number of tiers that can be allocated using KVM depends on the number of PCI slots availabe. For example, KVM provides 32 PCI slots, which are used to connect several devices, e.g. CD-ROM, keyboard, etc. Every ACS VR already consumes 9 slots of the 32 available; thus, in KVM we can have 23 slots for new tiers to be added. This PR updates the `vpc.max.networks` setting to `ConfigKey` and changes its scope to the cluster level, as the maximum number of networks per VPC depends on the hypervisor where the VR is deployed. The setting value is defined based on the cluster in which the VPC's VR is running, using the lowest value found if the VPC has more than one VR and they are in different clusters. If the VPC does not have a VR, the value defined in the global setting is used. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [X] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? I changed the `vpc.max.networks` value in the following resources: - Global setting: 3; - `cluster-test`: 7; - `cluster-test2`: 5. I created 3 VPCs: - VPC1: without VRs; - VPC2: VR within `cluster-test`; - VPC3: VRs within `cluster-test` and `cluster-test2`. Then, I verfiied that the `vpc.max.networks` setting value was: - 3 in VPC1; - 7 in VPC2; - 5 in VPC3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
