shwstppr commented on code in PR #8935:
URL: https://github.com/apache/cloudstack/pull/8935#discussion_r1570119257
##########
api/src/main/java/com/cloud/user/ResourceLimitService.java:
##########
@@ -239,13 +239,31 @@ public interface ResourceLimitService {
void updateTaggedResourceLimitsAndCountsForAccounts(List<AccountResponse>
responses, String tag);
void updateTaggedResourceLimitsAndCountsForDomains(List<DomainResponse>
responses, String tag);
void checkVolumeResourceLimit(Account owner, Boolean display, Long size,
DiskOffering diskOffering) throws ResourceAllocationException;
+
+ void checkDiskOfferingChange(Account owner, Boolean display, Long
currentSize, Long newSize,
+ DiskOffering currentOffering, DiskOffering newOffering) throws
ResourceAllocationException;
+
void incrementVolumeResourceCount(long accountId, Boolean display, Long
size, DiskOffering diskOffering);
void decrementVolumeResourceCount(long accountId, Boolean display, Long
size, DiskOffering diskOffering);
+
+ void handleServiceOfferingChange(long accountId, Boolean display, Long
currentCpu, Long newCpu, Long currentMemory,
Review Comment:
As these new methods are not part of Volume/VM service, should we prefix
them with Volume/Vm for clarity?
```suggestion
void handleVmServiceOfferingChange(long accountId, Boolean display, Long
currentCpu, Long newCpu, Long currentMemory,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
