abh1sar commented on code in PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1576888091
########## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtStoragePoolDef.java: ########## @@ -187,6 +208,13 @@ public String toString() { storagePoolBuilder.append("<path>" + _targetPath + "</path>\n"); storagePoolBuilder.append("</target>\n"); } + if (_poolType == PoolType.NETFS && _nfsopts != null) { + storagePoolBuilder.append("<fs:mount_opts>\n"); + for (Map.Entry<String, String> options : _nfsopts.entrySet()) { + storagePoolBuilder.append("<fs:option name='" + options.getKey() + "'/>\n"); + } + storagePoolBuilder.append("</fs:mount_opts>\n"); Review Comment: fs:mount_opts have to be added after the target tag on line 209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org