DaanHoogland commented on code in PR #8924:
URL: https://github.com/apache/cloudstack/pull/8924#discussion_r1579014313
##########
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVNCHandler.java:
##########
@@ -104,20 +105,20 @@ public void onConnect(final Session session) throws
IOException, InterruptedExce
try {
port = Integer.parseInt(portStr);
} catch (NumberFormatException e) {
- logger.error("Invalid port value in query string: {}. Expected a
number.", portStr, e);
+ logger.error(String.format("Invalid port value in query string:
%s. Expected a number.", portStr), e);
Review Comment:
I see, That was a good initiative back in 2013, to create a library facade,
it had not been implemented fully in the project though;
```
// logger facility for dynamic switch between console logger used in Applet
and log4j based logger
```
This might be an oversight in the log4j migration.
`com.cloud.consoleproxy.ConsoleProxyLoggerFactory` is still using log4j v1
classes under the hood.
I personally think we should have implemented such a proxy library, for the
whole project and implemented log4j under the hood. I think for now we will
have to do with 'fixing' the console proxy classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
