DaanHoogland commented on code in PR #8980:
URL: https://github.com/apache/cloudstack/pull/8980#discussion_r1582636329
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -3341,8 +3343,14 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
_resourceLimitMgr.decrementResourceCount(networkFinal.getAccountId(),
ResourceType.network, networkFinal.getDisplayNetwork());
}
}
+ return deletedVlans.second();
}
});
+ if (CollectionUtils.isNotEmpty(deletedVlanRangeToPublish)) {
+ for (VlanVO vlan : deletedVlanRangeToPublish) {
+ _messageBus.publish(_name,
MESSAGE_DELETE_VLAN_IP_RANGE_EVENT, PublishScope.LOCAL, vlan);
+ }
+ }
Review Comment:
new method?
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -5962,7 +5960,12 @@ public boolean deleteVlanIpRange(final
DeleteVlanIpRangeCmd cmd) {
throw new InvalidParameterValueException("Please specify a valid
IP range id.");
}
- return
deleteVlanAndPublicIpRange(CallContext.current().getCallingUserId(), vlanDbId,
CallContext.current().getCallingAccount());
+ VlanVO deletedVlan =
deleteVlanAndPublicIpRange(CallContext.current().getCallingUserId(), vlanDbId,
CallContext.current().getCallingAccount());
+ if (deletedVlan != null) {
+ messageBus.publish(_name, MESSAGE_DELETE_VLAN_IP_RANGE_EVENT,
PublishScope.LOCAL, deletedVlan);
+ return true;
+ }
+ return false;
Review Comment:
new method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
