weizhouapache commented on PR #8976:
URL: https://github.com/apache/cloudstack/pull/8976#issuecomment-2083254280
> > good catch @GaOrtiga
> > I wonder if it is better to consider all the null params
> > ```
> >
> > + Object.keys(args).forEach((key) => (args[key] == null) &&
delete args[key])
> > api('addHost', {}, 'POST', args).then(json => {
> > ```
>
> I do not think this would be necessary, `host tags` is the only argument
on the `addhost` section of this form that is not required, therefore it is the
only one that can be null.
that's ok, thanks @GaOrtiga
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
