DaanHoogland commented on PR #8643: URL: https://github.com/apache/cloudstack/pull/8643#issuecomment-2085042112
> code looks good > > @DaanHoogland a suggestion, can you add encryptformat to the VolumeResponse ? (admin only) We could do @weizhouapache , but as this is not touching the actual response object but only the selection criteria, it seems to be a separate issue to me. The Cmd type is not know at the time of Response creation. It goes two levels deep onto the stack in Helper classes. `ViewResponseHelper::createVolumeResponse(..)` > `ApiDBUtils::newVolumeResponse(..)/fillVolumeData(..)`. This unless we want to always add the encryption type of course. In that case it is no effort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
