bernardodemarco commented on PR #9031: URL: https://github.com/apache/cloudstack/pull/9031#issuecomment-2093756320
@DaanHoogland, thanks for your review! When I started developing this PR I had also considered converting the `*.smtp.enabledSecurityProtocols` settings to `Kind.CSV`. However, I've noticed some issues with that. The settings expect a whitespace-separated list of predefined values. The `Kind.CSV` type, on the other hand, expects a comma-separated list of values that are not predefined. This means that the operator is able to add any additional values, for example:  As a consequence of this, the `Kind.CSV` UI component could not be reused. Another problem that I've identified is that the current settings' values would need to be normalized into a comma-separated list. Additionally, the source code would need to be reviewed and adjusted in order to interpret correctly the new structure of values. On top of that, I've identified that the `Kind.Order` UI component could properly be reused to display the `Kind.WhitespaceSeparatedListWithOptions` settings without introducing big changes to the code. As shown in the screenshots available in the PR's description, the operator can easily select and browse through the available options, but it is not able to add additional values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
