weizhouapache commented on code in PR #9059:
URL: https://github.com/apache/cloudstack/pull/9059#discussion_r1593932547
##########
server/src/main/java/com/cloud/network/IpAddressManagerImpl.java:
##########
@@ -732,8 +732,9 @@ public boolean disassociatePublicIpAddress(long addrId,
long userId, Account cal
PublicIpQuarantine publicIpQuarantine = null;
// Cleanup all ip address resources - PF/LB/Static nat rules
if (!cleanupIpResources(addrId, userId, caller)) {
- success = false;
- s_logger.warn("Failed to release resources for ip address id=" +
addrId);
+ String msg = String.format("Failed to release resources for ip
address id=%s", addrId);
+ s_logger.error(msg);
+ throw new CloudRuntimeException(msg);
Review Comment:
it does, but I think the process should be stopped here if the error happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
