weizhouapache commented on PR #8603:
URL: https://github.com/apache/cloudstack/pull/8603#issuecomment-2103240845
> > @GutoVeronezi why do you think the new log is way more clear......
>
> The previous message says: `Global setting endpoint.url has to be set to
the Management Server's API endpoint`; however, it validates if the setting has
`localhost` in the name or it is blank. Without the change, operators will have
to check the code to know that.
@GutoVeronezi
what I disagree is not the new error in the log (actually I like it), see
below
LOGGER.error("Global setting [{}] cannot contain localhost or be
blank. Current value: {}", ApiServletPath.key(), csUrl);
What I disagree is the message in the exception, see below
throw new InvalidParameterValueException("Unable to complete
this operation. Contact your cloud admin.");
My suggestion is
- update the description of the global setting to emphasize it should not be
empty or contain localhost
- update the message in the exception to include more information, for
example "Unable to xxx because endpoint url is not configured correctly, please
xxxx"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
