JoaoJandre commented on code in PR #9093:
URL: https://github.com/apache/cloudstack/pull/9093#discussion_r1608160810
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/utils/KubernetesClusterUtil.java:
##########
@@ -266,13 +266,11 @@ public static boolean
isKubernetesClusterControlVmRunning(final KubernetesCluste
socket.connect(new InetSocketAddress(ipAddress, port), 10000);
controlVmRunning = true;
} catch (IOException e) {
- if (LOGGER.isInfoEnabled()) {
- LOGGER.info(String.format("Waiting for Kubernetes cluster
: %s control node VMs to be accessible", kubernetesCluster.getName()));
- }
+ LOGGER.info("Waiting for Kubernetes cluster : %s control node
VMs to be accessible", kubernetesCluster.getName());
try {
Thread.sleep(10000);
} catch (InterruptedException ex) {
- LOGGER.warn(String.format("Error while waiting for
Kubernetes cluster : %s control node VMs to be accessible",
kubernetesCluster.getName()), ex);
+ LOGGER.warn("Error while waiting for Kubernetes cluster :
%s control node VMs to be accessible", kubernetesCluster.getName(), ex);
Review Comment:
```suggestion
LOGGER.warn("Error while waiting for Kubernetes cluster
: {} control node VMs to be accessible", kubernetesCluster.getName(), ex);
```
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/utils/KubernetesClusterUtil.java:
##########
@@ -266,13 +266,11 @@ public static boolean
isKubernetesClusterControlVmRunning(final KubernetesCluste
socket.connect(new InetSocketAddress(ipAddress, port), 10000);
controlVmRunning = true;
} catch (IOException e) {
- if (LOGGER.isInfoEnabled()) {
- LOGGER.info(String.format("Waiting for Kubernetes cluster
: %s control node VMs to be accessible", kubernetesCluster.getName()));
- }
+ LOGGER.info("Waiting for Kubernetes cluster : %s control node
VMs to be accessible", kubernetesCluster.getName());
Review Comment:
```suggestion
LOGGER.info("Waiting for Kubernetes cluster : {} control
node VMs to be accessible", kubernetesCluster.getName());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
