vishesh92 commented on code in PR #9070:
URL: https://github.com/apache/cloudstack/pull/9070#discussion_r1616851718


##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##########
@@ -1526,6 +1575,8 @@ public KubernetesClusterConfigResponse 
getKubernetesClusterConfig(GetKubernetesC
     }
 
     @Override
+    @ActionEvent(eventType = 
KubernetesClusterEventTypes.EVENT_KUBERNETES_CLUSTER_SCALE,
+            eventDescription = "scaling Kubernetes cluster", async = true)
     public boolean scaleKubernetesCluster(ScaleKubernetesClusterCmd cmd) 
throws CloudRuntimeException {

Review Comment:
   ```java
   CallContext.current().setEventDetails("Current min size: ?? New min size: 
??");
   ```
   Can we also set event details here? It would be good to have extra 
information about the change itself in events.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to