weizhouapache commented on issue #8907: URL: https://github.com/apache/cloudstack/issues/8907#issuecomment-2138136441
> > Ideally, incremental backups, or a base snapshot and a number of snapshot deltas, become abstract concepts in ACS, and drivers for primary storage can implement the operations for the abstract concepts. > > > > My background is LINSTOR. LINSTOR leverages LVM's dm-thin to take snapshots; it uses [thin-send-recv](https://github.com/LINBIT/thin-send-recv/commits/master/) to generate snapshot deltas. You can find more about it [here](https://linbit.com/drbd-user-guide/linstor-guide-1_0-en/#s-linstor-scheduled-backup-shipping) > > > > But of course, many other primary storage solutions that are available for ACS probably also support continuous preservation of snapshot-deltas. > > I'm not sure I got your point @Philipp-Reisner, but I'll not be touching any storage drivers in this implementation. This will be the native ACS implementation for NFS/Local/SharedMountPoint storages. We have plans to add incremental snapshots for Ceph, but then we will have to use Ceph's back-end for it. If others want to implement this feature for other drivers, they are free to do so. My understanding is, there should be some methods in the storage interfaces. Storage providers only need to implement the methods in their plugins, without touching the service layer. I did not look into the design carefully. I think it is better to allow users to choose if the snapahot is full or incremental when they create snapshots. Of course you can add global settings to disable the options, which might be useful for cloud operators. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
