weizhouapache commented on code in PR #9191:
URL: https://github.com/apache/cloudstack/pull/9191#discussion_r1633138413
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java:
##########
@@ -56,7 +56,7 @@ public class CreateServiceOfferingCmd extends BaseCmd {
@Parameter(name = ApiConstants.CPU_NUMBER, type = CommandType.INTEGER,
required = false, description = "the CPU number of the service offering")
private Integer cpuNumber;
- @Parameter(name = ApiConstants.CPU_SPEED, type = CommandType.INTEGER,
required = false, description = "the CPU speed of the service offering in MHz.")
+ @Parameter(name = ApiConstants.CPU_SPEED, type = CommandType.INTEGER,
required = false, description = "the CPU speed of the service offering in MHz.
In the case cgroups are used on KVM, this is interpreted to calculate the
maximum number of shares.")
Review Comment:
according to https://libvirt.org/formatdomain.html#cpu-tuning
`
The optional shares element specifies the proportional weighted share for
the domain. If this is omitted, it defaults to the OS provided defaults. NB,
There is no unit for the value, it's a relative measure based on the setting of
other VM, e.g. A VM configured with value 2048 will get twice as much CPU time
as a VM configured with value 1024. The value should be in range [2, 262144]
using cgroups v1, [1, 10000] using cgroups v2. Since 0.9.0
`
I am not sure if "the maximum number of shares" is correct.
maybe we could also add the link above in the description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
