sureshanaparti commented on code in PR #9213:
URL: https://github.com/apache/cloudstack/pull/9213#discussion_r1635887296
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -5336,18 +5336,18 @@ public void setInterfaceDefQueueSettings(Map<String,
String> details, Integer cp
/*
Scp volume from remote host to local directory
*/
- public String copyVolume(String srcIp, String username, String password,
String localDir, String remoteFile, String tmpPath) {
+ public String copyVolume(String srcIp, String username, String password,
String localDir, String remoteFile, String tmpPath, int timeoutInSecs) {
try {
String outputFile = UUID.randomUUID().toString();
StringBuilder command = new StringBuilder("qemu-img convert -O
qcow2 ");
command.append(remoteFile);
- command.append(" "+tmpPath);
+ command.append(" " + tmpPath);
command.append(outputFile);
- s_logger.debug("Converting remoteFile: "+remoteFile);
- SshHelper.sshExecute(srcIp, 22, username, null, password,
command.toString());
- s_logger.debug("Copying remoteFile to: "+localDir);
+ s_logger.debug(String.format("Converting remote disk file: %s,
output file: %s (timeout: %d secs)", remoteFile, outputFile, timeoutInSecs));
Review Comment:
will check, and remove if required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
