rp- commented on PR #8796: URL: https://github.com/apache/cloudstack/pull/8796#issuecomment-2164598385
> @DaanHoogland, yes, the code LGTM. > > > Instance VM snapshots are not fully atomic but with the > > create multi snapshot feature as good as it gets. > > @rp-, a suggestion here - you can add a configuration setting with which you can enable to freeze the VM (if the users want the snapshots to be consistent) I'll keep that in mind, but wouldn't want to change this PR now to much, before the 4.19.1 release. Also, I'm on vacation starting next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org