DaanHoogland commented on PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2164942867

   > @DaanHoogland separate methods are called allow publishing of events of 
different types. Initially, I did the same. Other way to allow publishing of 
correct events could be manually calling 
`ActionEventUtils.onStarted/onCompleted/onError`
   
   not sure if we understand each other @shwstppr , couldn't 
`routerService.startRouterForHA(vm, params, planner);` be just called 
`routerService.startForHA(vm, params, planner);` and 
`consoleProxyManager.startProxyForHA(vm, params, planner);` be called 
`consoleProxyManager.startForHA(vm, params, planner);` and so on?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to