BryanMLima commented on code in PR #9235:
URL: https://github.com/apache/cloudstack/pull/9235#discussion_r1638767609
##########
server/src/main/java/com/cloud/api/query/dao/VolumeJoinDaoImpl.java:
##########
@@ -283,6 +283,19 @@ public VolumeResponse newVolumeResponse(ResponseView view,
VolumeJoinVO volume)
return volResponse;
}
+ private static ServiceOffering
getServiceOfferingForDiskOffering(VolumeJoinVO volume, DiskOffering
computeOnlyDiskOffering) {
+ ServiceOffering serviceOffering = null;
+ // first try existing ones
+ if (computeOnlyDiskOffering != null) {
+ serviceOffering =
ApiDBUtils.findServiceOfferingByComputeOnlyDiskOffering(volume.getDiskOfferingId(),
false);
+ }
+ // else try removed ones
Review Comment:
@DaanHoogland, could you change this comment to the Javadoc of the method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
