DaanHoogland commented on code in PR #9248:
URL: https://github.com/apache/cloudstack/pull/9248#discussion_r1642441566
##########
plugins/hypervisors/xenserver/src/main/java/org/apache/cloudstack/hypervisor/xenserver/ExtraConfigurationUtility.java:
##########
@@ -68,12 +75,13 @@ private static void
applyConfigWithNestedKeyValue(Connection conn, VM vm, Map<St
}
try {
+ // map-param param with '_'
Review Comment:
do we need this comment? what does it mean?
##########
plugins/hypervisors/xenserver/src/main/java/org/apache/cloudstack/hypervisor/xenserver/ExtraConfigurationUtility.java:
##########
@@ -101,6 +109,7 @@ private static void applyConfigWithKeyValue(Connection
conn, VM vm, Map<String,
}
try {
+ // param with '_'
Review Comment:
do we need this comment? it is a bit unclear if this is enforced or a
contextual condition or ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
