sureshanaparti commented on code in PR #7226:
URL: https://github.com/apache/cloudstack/pull/7226#discussion_r1650101017
##########
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java:
##########
@@ -458,6 +459,16 @@ protected Answer migrateVolumeToPool(DataObject srcData,
DataObject destData) {
StoragePool srcPool =
(StoragePool)dataStoreMgr.getDataStore(srcData.getDataStore().getId(),
DataStoreRole.Primary);
StoragePool destPool =
(StoragePool)dataStoreMgr.getDataStore(destData.getDataStore().getId(),
DataStoreRole.Primary);
MigrateVolumeCommand command = new
MigrateVolumeCommand(volume.getId(), volume.getPath(), destPool,
volume.getAttachedVmName(), volume.getVolumeType(), waitInterval,
volume.getChainInfo());
+
+ if (volume.getpayload() instanceof DiskOfferingVO) {
+ DiskOfferingVO offering = (DiskOfferingVO) volume.getpayload();
+ Long newIops = null;
+ if (offering.getIopsReadRate() != null &&
offering.getIopsWriteRate() != null) {
+ newIops = offering.getIopsReadRate() +
offering.getIopsWriteRate();
+ }
+ command.setNewIops(newIops);
Review Comment:
only IOPS are considered, should consider other attributes in the new disk
offering?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
