rg9975 opened a new pull request, #8889: URL: https://github.com/apache/cloudstack/pull/8889
### Description This PR makes a number of bug fixes to the Primera and Pure storage array discovered in working environments after the release of 4.19.0.0. <!--- Describe your changes in DETAIL - And how has behavior functionally changed. --> The following items are addressed: 1. Switched to a host-centric rather than hostgroup-centric vlun assignment model. hostgroup-centric works better for shared filesystems but the direct volume attach method for these drivers is better suited to per-host vlun assignments. This required changes to how vlun id's are stored as well as a number of changes in the storage framework to add missing grantAccess/revokeAccess calls or reorder those calls so data is properly available in the Disk objects sent to agents. 2. Improved error handling and logging in the storage portion of the agent when copying volumes. 3. Fix to properly handle storage tag to storage provider mapping when migrating disks to a different storage provider and selecting a new disk offering. 4. Fix an issue related to template removal on primary storage for Pure when all volumes using the template are deleted. Pure storage 'saves' the volume in a Deleted area for some period of time after deletion so any recreation of the volume on subsequent volume creations will trigger an error. The fix renames the volume prior to deletion by appending a timestamp. 5. Small issues with oAuth login discovered during testing when incorrect user password is entered at the login prompt. 6. Several small logging cleanups in a few modules that were producing unnecessary noise at INFO level. 7. Various exception/error handling improvements in storage classes to improve triage/debugging of storage/volume issues. 8. Fix for issue #8789 . <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviors, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [X] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [X] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? The standard test suite at plugins/storage/volume/adaptive/README.md was run against a local installation of Pure Flasharray and HPE Primera. <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? Test cases include using the built-in NFS driver in combination with both Flasharray and Primera, moving volumes back and forth between all 3 file systems, and testing standard functions of NFS with these drivers in place. <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
