DaanHoogland commented on code in PR #9131:
URL: https://github.com/apache/cloudstack/pull/9131#discussion_r1668096082
##########
core/src/main/resources/META-INF/cloudstack/storage/spring-lifecycle-storage-context-inheritable.xml:
##########
@@ -76,7 +76,7 @@
<property name="typeClass"
value="org.apache.cloudstack.engine.subsystem.api.storage.DataMotionStrategy" />
</bean>
-
-
+
+
Review Comment:
```suggestion
```
##########
server/src/main/resources/META-INF/cloudstack/server-fencer/spring-server-fencer-context.xml:
##########
@@ -27,11 +27,11 @@
http://www.springframework.org/schema/context/spring-context.xsd";
>
-
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_createusers.xml:
##########
@@ -307,6 +307,6 @@ under the License.
</item>
</returnvalue>
</command>
-
+
Review Comment:
```suggestion
```
##########
engine/storage/integration-test/src/test/resources/testng.xml:
##########
@@ -40,11 +40,11 @@
<parameter name="image-install-path" value="template/tmpl/1/5/"/>
-
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/pickuser_rootadmin_vs_domainlevel1admin.xml:
##########
@@ -67,10 +67,10 @@ under the License.
<param>domainlevel1</param>
</item>
</returnvalue>
- </command>
-
+ </command>
-<!-- User who executes second set of commands -->
+
Review Comment:
```suggestion
```
##########
test/metadata/func/flatnetwork.xml:
##########
@@ -334,8 +334,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
+
<command>
Review Comment:
```suggestion
<command>
```
##########
test/metadata/func/ha.xml:
##########
@@ -337,9 +337,9 @@ under the License.
<param>instance_name_ha</param>
</item>
</parameters>
- </command>
-
-
+ </command>
+
+
Review Comment:
```suggestion
```
##########
engine/storage/integration-test/src/test/resources/testng.xml:
##########
@@ -27,10 +27,10 @@
<parameter name="primary-storage-want-to-add"
value="nfs://192.168.56.2/opt/storage/primarynfs"/>
<parameter name="devcloud-local-storage-uuid"
value="cd10cac1-4772-92e5-5da6-c2bc16b1ce1b"/>
<parameter name="devcloud-host-uuid"
value="759ee4c9-a15a-297b-67c6-ac267d8aa429"/>
- <parameter name="devcloud-secondary-storage"
value="nfs://192.168.56.10/opt/storage/secondary"/>
+ <parameter name="devcloud-secondary-storage"
value="nfs://192.168.56.10/opt/storage/secondary"/>
<parameter name="primary-storage-uuid-want-to-add"
value="759ee4c9-a15a-297b-67c6-ac267d8abe29" />
<parameter name="script-path" value="/Users/minc/dev/cloud-asf" />
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/private_templates.xml:
##########
@@ -591,8 +591,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
+
Review Comment:
```suggestion
```
##########
plugins/user-authenticators/plain-text/src/main/resources/META-INF/cloudstack/plaintext/spring-plaintext-context.xml:
##########
@@ -31,5 +31,5 @@
<property name="name" value="PLAINTEXT" />
</bean>
-
+
Review Comment:
```suggestion
```
##########
services/secondary-storage/server/src/main/resources/META-INF/cloudstack/secondary-storage-discoverer/spring-secondary-storage-discoverer-context.xml:
##########
@@ -32,5 +32,5 @@
<property name="name" value="SecondaryStorage" />
</bean>
-
+
Review Comment:
```suggestion
```
##########
plugins/storage/volume/default/src/main/resources/META-INF/cloudstack/storage-volume-default/spring-storage-volume-default-context.xml:
##########
@@ -31,5 +31,5 @@
class="org.apache.cloudstack.storage.datastore.provider.CloudStackPrimaryDataStoreProviderImpl"
/>
-
+
Review Comment:
```suggestion
```
##########
plugins/user-two-factor-authenticators/totp/src/main/resources/META-INF/cloudstack/totp/spring-google-context.xml:
##########
@@ -31,5 +31,5 @@
<property name="name" value="TOTP" />
</bean>
-
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_cleanup.xml:
##########
@@ -55,8 +55,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_createusers.xml:
##########
@@ -218,8 +218,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/private_templates.xml:
##########
@@ -230,8 +230,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_createusers.xml:
##########
@@ -173,8 +173,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
plugins/user-two-factor-authenticators/static-pin/src/main/resources/META-INF/cloudstack/staticpin/spring-staticpin-context.xml:
##########
@@ -31,5 +31,5 @@
<property name="name" value="STATICPIN" />
</bean>
-
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_verify_part1.xml:
##########
@@ -84,17 +84,17 @@ under the License.
<item getparam="true">
<name>diskofferingid</name>
<param>globaldiskofferingid</param>
- </item>
+ </item>
</parameters>
<returnvalue>
<item setparam="true">
<name>id</name>
<param>volumeid</param>
</item>
</returnvalue>
- </command>
-
-
+ </command>
+
+
Review Comment:
```suggestion
```
##########
test/metadata/adapter.xml:
##########
@@ -272,7 +272,7 @@ under the License.
<!-- <filename>../metadata/func/flatnetwork.xml</filename>-->
<!-- <testname>Flat network test</testname>-->
<!-- </test>-->
-
+
Review Comment:
I would suggest removing all this excessive code in comment (maybe out of
scope for this)
##########
test/metadata/delegatedAdmin/delegated_admin_verify_part1.xml:
##########
@@ -123,8 +123,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_verify_part1.xml:
##########
@@ -67,8 +67,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_verify_part1.xml:
##########
@@ -159,9 +159,9 @@ under the License.
<param>registeredtemplateid</param>
</item>
</returnvalue>
- </command>
-
-
+ </command>
+
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_verify_part1.xml:
##########
@@ -244,8 +244,8 @@ under the License.
<param>snapshotpolicyid</param>
</item>
</returnvalue>
- </command>
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_verify_part1.xml:
##########
@@ -258,14 +258,14 @@ under the License.
<param>globalzoneid</param>
</item>
</parameters>
- <returnvalue>
+ <returnvalue>
<item setparam="true">
<name>ipaddress</name>
<param>ipaddress</param>
</item>
</returnvalue>
</command>
-
+
Review Comment:
```suggestion
```
##########
test/metadata/adapter.xml:
##########
@@ -330,7 +330,7 @@ under the License.
<filename>../metadata/delegatedAdmin/delegated_admin_verify_part2.xml</filename>
<filename>../metadata/delegatedAdmin/delegated_admin_cleanup.xml</filename> -->
<!-- </test> -->
-
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/pickuser_domainlevel1_domainlevel2.xml:
##########
@@ -67,10 +67,10 @@ under the License.
<param>domainlevel1</param>
</item>
</returnvalue>
- </command>
-
+ </command>
-<!-- User who executes second set of commands -->
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_verify_part1.xml:
##########
@@ -367,9 +367,9 @@ under the License.
<param>lbid</param>
</item>
</returnvalue>
- </command>
-
-
+ </command>
+
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/pickuser_domainlevel2_child_domainlevel1.xml:
##########
@@ -67,10 +67,10 @@ under the License.
<param>domainlevel1</param>
</item>
</returnvalue>
- </command>
-
+ </command>
-<!-- User who executes second set of commands -->
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/pickuser_domainlevel1admin_domainlevel1admin.xml:
##########
@@ -67,10 +67,10 @@ under the License.
<param>domainlevel1</param>
</item>
</returnvalue>
- </command>
-
+ </command>
-<!-- User who executes second set of commands -->
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/pickuser_domainlevel1admin_rootadmin.xml:
##########
@@ -67,10 +67,10 @@ under the License.
<param>domainlevel1</param>
</item>
</returnvalue>
- </command>
-
+ </command>
-<!-- User who executes second set of commands -->
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/pickuser_domainlevel2_nonchild_domainlevel1.xml:
##########
@@ -67,10 +67,10 @@ under the License.
<param>domainlevel1</param>
</item>
</returnvalue>
- </command>
-
+ </command>
-<!-- User who executes second set of commands -->
+
Review Comment:
```suggestion
```
##########
test/metadata/func/flatnetwork.xml:
##########
@@ -334,8 +334,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/pickuser_domainlevel2_rootadmin1.xml:
##########
@@ -67,10 +67,10 @@ under the License.
<param>domainlevel1</param>
</item>
</returnvalue>
- </command>
-
+ </command>
-<!-- User who executes second set of commands -->
+
Review Comment:
```suggestion
```
##########
test/metadata/func/localstorage_volume_test.xml:
##########
@@ -73,11 +73,11 @@ under the License.
<item getparam="true">
<name>diskofferingid</name>
<param>globaldiskofferingid</param>
- </item>
+ </item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/pickuser_rootadmin1_rootadmin2.xml:
##########
@@ -67,10 +67,10 @@ under the License.
<param>domainlevel1</param>
</item>
</returnvalue>
- </command>
-
+ </command>
-<!-- User who executes second set of commands -->
+
Review Comment:
```suggestion
```
##########
test/metadata/func/flatnetwork.xml:
##########
@@ -438,8 +438,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/flatnetwork.xml:
##########
@@ -383,8 +383,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/flatnetwork.xml:
##########
@@ -421,8 +421,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/flatnetwork.xml:
##########
@@ -515,10 +515,10 @@ under the License.
<value>120</value>
</item>
</parameters>
- </command>
-
-
-<!-- Delete user as a part of cleanup -->
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/flatnetwork.xml:
##########
@@ -474,8 +474,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/portforwarding.xml:
##########
@@ -781,13 +781,13 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/ha.xml:
##########
@@ -131,8 +131,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/roughflatstress.xml:
##########
@@ -398,8 +398,8 @@ under the License.
</item>
--> </parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/localstorage_volume_test.xml:
##########
@@ -110,9 +110,9 @@ under the License.
</item>
</parameters>
</command>
-
-
-
+
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/localstorage_volume_test.xml:
##########
@@ -145,9 +145,9 @@ under the License.
</item>
</parameters>
</command>
-
-
-
-
-
+
+
+
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/private_templates.xml:
##########
@@ -294,8 +294,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/private_templates.xml:
##########
@@ -251,8 +251,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -1463,8 +1463,8 @@ under the License.
</item>
</returnvalues>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/sanity.xml:
##########
@@ -272,9 +272,9 @@ under the License.
<param>routerid</param>
</item>
</returnvalue>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/iso.xml:
##########
@@ -267,8 +267,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -3915,37 +3915,37 @@ under the License.
<param>diskid</param>
</item>
</parameters>
- </command>
+ </command>
<!-- Test case #750 - listAlerts command -->
<command>
<name>listAlerts</name>
<testcase>750</testcase>
<empty>false</empty>
</command>
-
+
<!-- Test case #974 - listCapacity command -->
<command>
<name>listCapacity</name>
<testcase>974</testcase>
<empty>false</empty>
</command>
-
+
<!-- Test case #975 - listHosts command -->
<command>
<name>listHosts</name>
<empty>false</empty>
<testcase>975</testcase>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -2503,8 +2503,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/vmapi.xml:
##########
@@ -886,6 +886,6 @@ under the License.
</item>
</parameters>
</command>
-
-
-</vmapi>
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -4094,9 +4094,9 @@ under the License.
</item>
</parameters>
</command>
-
-
-<!-- Test case # - register Iso command -->
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -2964,8 +2964,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/iso.xml:
##########
@@ -545,8 +545,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -4258,8 +4258,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -3030,9 +3030,9 @@ under the License.
</item>
</parameters>
</command>
-
-
+
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_verify_part2.xml:
##########
@@ -756,8 +756,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -2941,8 +2941,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/sanity.xml:
##########
@@ -372,7 +372,7 @@ under the License.
<param>accountid</param>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/loadbalancers.xml:
##########
@@ -1984,9 +1984,9 @@ under the License.
<value>1</value>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -2465,13 +2465,13 @@ under the License.
<param>lbid</param>
</item>
</parameters>
- </command>
-
+ </command>
+
<!-- PORT FORWARDING RULES SECTION -->
-
+
<!-- ADD TEST CASES FOR IP FORWARDING HERE!!! -->
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/loadbalancers.xml:
##########
@@ -1459,8 +1459,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/userapi.xml:
##########
@@ -541,8 +541,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/iso.xml:
##########
@@ -585,8 +585,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -3785,9 +3785,9 @@ under the License.
<value>65</value>
</item>
</returnvalue>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/iso.xml:
##########
@@ -487,8 +487,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -2631,17 +2631,17 @@ under the License.
<item getparam="true">
<name>diskofferingid</name>
<param>globaldiskofferingid</param>
- </item>
+ </item>
</parameters>
<returnvalue>
<item setparam="true">
<name>id</name>
<param>datavolumeid</param>
</item>
</returnvalue>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/vmapi.xml:
##########
@@ -406,8 +406,8 @@ under the License.
<param>accountid</param>
</item>
</parameters>
- </command>
-
+ </command>
+
<command>
Review Comment:
```suggestion
<command>
```
##########
test/metadata/func/sanity.xml:
##########
@@ -167,8 +167,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/sanity.xml:
##########
@@ -247,8 +247,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_verify_part2.xml:
##########
@@ -419,9 +419,9 @@ under the License.
<param>account1</param>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/expunge.xml:
##########
@@ -584,8 +584,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -596,11 +596,11 @@ under the License.
</returnvalue>
</command>
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -2536,9 +2536,9 @@ under the License.
</item>
</returnvalue>
</command>
-
-
-<!-- VOLUME COMMANDS -->
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -3002,8 +3002,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/templatedwnldstress.xml:
##########
@@ -411,9 +411,9 @@ under the License.
<param>expunge.interval</param>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -3549,9 +3549,9 @@ under the License.
</parameters>
<returnvalue>
</returnvalue>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_verify_part2.xml:
##########
@@ -162,8 +162,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/vmapi.xml:
##########
@@ -693,8 +693,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -2671,8 +2671,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/expunge.xml:
##########
@@ -823,10 +823,10 @@ under the License.
<param>snapshotpath</param>
</item>
</parameters>
- </command>
-
-
-
+ </command>
+
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/expunge.xml:
##########
@@ -535,9 +535,9 @@ under the License.
<param>expunge.interval</param>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/expunge.xml:
##########
@@ -765,9 +765,9 @@ under the License.
<param>snapshotpath</param>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -1995,8 +1995,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/userapi.xml:
##########
@@ -512,8 +512,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/securitygroups.xml:
##########
@@ -715,8 +715,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -2420,9 +2420,9 @@ under the License.
<param>vmid</param>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/loadbalancers.xml:
##########
@@ -803,8 +803,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -2305,8 +2305,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/roughflatstress.xml:
##########
@@ -663,9 +663,9 @@ under the License.
</item>
</parameters>
</command>
-
-
-<!-- Delete user as a part of cleanup -->
+
Review Comment:
```suggestion
```
##########
test/metadata/func/securitygroups.xml:
##########
@@ -752,10 +752,10 @@ under the License.
<value>120</value>
</item>
</parameters>
- </command>
-
-
-<!-- Delete user as a part of cleanup -->
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -215,12 +215,12 @@ under the License.
<item>
<name>domain</name>
<value>ROOT</value>
- </item>
+ </item>
</returnvalue>
</command>
-
-
-
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/iso.xml:
##########
@@ -315,8 +315,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/iso.xml:
##########
@@ -759,9 +759,9 @@ under the License.
</item>
</returnvalue>
</command>
-
-
-
+
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -4372,9 +4372,9 @@ under the License.
<param>consoleid</param>
</item>
</parameters>
- </command>
-
-
+ </command>
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -3506,8 +3506,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -3851,9 +3851,9 @@ under the License.
<value>newdisk</value>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -4437,7 +4437,7 @@ under the License.
<param>accountid</param>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -4013,8 +4013,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -3282,9 +3282,9 @@ under the License.
</item>
</returnvalue>
</command>
-
-
-
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -3072,8 +3072,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/expunge.xml:
##########
@@ -986,8 +986,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/templatedwnldstress.xml:
##########
@@ -751,7 +751,7 @@ under the License.
<param>accountid</param>
</item>
</parameters>
- </command>
-
-
+ </command>
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/expunge.xml:
##########
@@ -718,9 +718,9 @@ under the License.
<param>expunge.interval</param>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/vmapi.xml:
##########
@@ -538,9 +538,9 @@ under the License.
<value>false</value>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -2286,9 +2286,9 @@ under the License.
<param>accountname</param>
</item>
</returnvalue>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/templatedwnldstress.xml:
##########
@@ -614,9 +614,9 @@ under the License.
<param>expunge.interval</param>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/iso.xml:
##########
@@ -879,8 +879,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_verify_part2.xml:
##########
@@ -37,9 +37,9 @@ under the License.
</item>
</returnvalue>
</command>
-
-
-<!-- VM RELATED COMMANDS -->
+
Review Comment:
```suggestion
```
##########
test/metadata/func/loadbalancers.xml:
##########
@@ -2030,7 +2030,7 @@ under the License.
<param>accountid</param>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/iso.xml:
##########
@@ -333,7 +333,7 @@ under the License.
</item>
</parameters>
</command>
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/vmapi.xml:
##########
@@ -707,7 +707,7 @@ under the License.
</item>
</parameters>
</command>
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/iso.xml:
##########
@@ -120,10 +120,10 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_verify_part2.xml:
##########
@@ -743,8 +743,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/userapi.xml:
##########
@@ -964,8 +964,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/delegatedAdmin/delegated_admin_verify_part2.xml:
##########
@@ -850,13 +850,13 @@ under the License.
<value>roundrobin</value>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -2606,8 +2606,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/userapi.xml:
##########
@@ -832,8 +832,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/userapi.xml:
##########
@@ -643,8 +643,8 @@ under the License.
<param>newdomainid</param>
</item>
</returnvalue>
- </command>
-
+ </command>
+
<command>
Review Comment:
```suggestion
<command>
```
##########
test/metadata/func/templatedwnldstress.xml:
##########
@@ -673,8 +673,8 @@ under the License.
</command>
<!-- Clean Up Section -->
-
-
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -3538,9 +3538,9 @@ under the License.
<value>35</value>
</item>
</returnvalue>
- </command>
-
-
+ </command>
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/userapi.xml:
##########
@@ -1239,8 +1239,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -3298,8 +3298,8 @@ under the License.
<returnvalue>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -3683,10 +3683,10 @@ under the License.
<value>1</value>
</item>
</parameters>
- </command>
-
-
-<!-- Test case #953 - createLimit command -->
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -4033,8 +4033,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -3833,9 +3833,9 @@ under the License.
</item>
</returnvalue>
</command>
-
-
-
+
+
Review Comment:
```suggestion
```
##########
test/metadata/func/userapi.xml:
##########
@@ -127,11 +127,11 @@ under the License.
<item>
<name>domainid</name>
<value>1</value>
- </item>
+ </item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/expunge.xml:
##########
@@ -548,9 +548,9 @@ under the License.
<param>expunge.interval</param>
</item>
</parameters>
- </command>
-
-
+ </command>
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -2724,10 +2724,10 @@ under the License.
<param>datavolumeid1</param>
</item>
</parameters>
- </command>
-
+ </command>
-<!-- SNAPSHOT COMMANDS -->
+
Review Comment:
```suggestion
```
##########
test/metadata/func/userapi.xml:
##########
@@ -623,8 +623,8 @@ under the License.
</item>
</parameters>
</command>
-
-
+
Review Comment:
```suggestion
```
##########
test/metadata/func/regression.xml:
##########
@@ -4069,8 +4069,8 @@ under the License.
</item>
</returnvalue>
</command>
-
-
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
