wido commented on code in PR #8389:
URL: https://github.com/apache/cloudstack/pull/8389#discussion_r1687527655
##########
utils/src/test/java/com/cloud/utils/UriUtilsTest.java:
##########
@@ -273,4 +273,16 @@ public void testIsUrlForCompressedFile() {
Assert.assertTrue(UriUtils.isUrlForCompressedFile("https://abc.com/xyz.gz";));
Assert.assertFalse(UriUtils.isUrlForCompressedFile("http://abc.com/xyz.qcow2";));
}
+
+ @Test
+ public void validateUrl() {
+ Pair<String, Integer> url1 =
UriUtils.validateUrl("https://www.cloudstack.org";);
+ Assert.assertEquals(url1.first(), "www.cloudstack.org");
+
+ Pair<String, Integer> url2 =
UriUtils.validateUrl("https://www.apache.org";);
+ Assert.assertEquals(url2.first(), "www.apache.org");
+
+ Pair<String, Integer> url3 =
UriUtils.validateUrl("https://ipv6.google.com";);
+ Assert.assertEquals(url3.first(), "ipv6.google.com");
Review Comment:
We need to make sure that this code can work with IPv6 as well. But the
problem is that the host where the build is running on doesn't support IPv6 and
thus fails to run the test properly. This also explains why it doesn't fail on
my local machines as they do have IPv6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
