abh1sar commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2264874354
> Hey @abh1sar > > Good to see you actually have a specification for such a big feature. Sadly we have too many PRs that change 2k+ lines with little to none specification. > > I have a few suggestions regarding the feature: > > 1. On the `file_share` table you have on the spec, I think that we are missing a `created` column, to track when the file_share was created. I would also add a `removed` column, to track when it was removed. > 2. On your FSM, add a final state called `Expunged`, that is reached when the `ExpungeOperation` is successful. > 3. I know that using shell scripts or python might be tempting, but these tend to be hard to maintain and expand without breaking. I would advise on going back to the idea of doing something similar to what is done for the CPVM/SSVM. Hi @JoaoJandre, I am afraid the specification is not upto date with the design changes that were discussed over the dev ML. Apologies for that. https://lists.apache.org/thread/rd4sborvzlpsw64o3mq257423ronnq53 I will update the spec asap. 1 and 2. I have the created, removed column and Expunge state in the implementation. 3. We have moved away from VR based model of using shell scripts and python code. Please refer to the ML discussion. The VM is deployed as a normal user VM and the userdata is used to push some udev rules to the VM. These udev rules take care of following operations : - Format and export the FS, first time a data volume is added to the VM - Resize the FS whenever the volume is resized We can think about using the agent model in future if required, but using Userdata allows us to implement the basic functionality that is very lightweight in terms of mgmt server - vm communication. Please let me know your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
