GaOrtiga commented on code in PR #9132:
URL: https://github.com/apache/cloudstack/pull/9132#discussion_r1713813784
##########
plugins/network-elements/juniper-contrail/src/main/java/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java:
##########
@@ -134,7 +134,7 @@ private ServiceVirtualMachine createServiceVM(DataCenter
zone, Account owner, Vi
} catch (InsufficientCapacityException ex) {
throw new CloudRuntimeException("Insufficient capacity", ex);
}
- CallContext.current().setEventDetails("Vm Id: " + svm.getId());
+ CallContext.current().setEventDetails("VM ID: " + svm.getId());
Review Comment:
@DaanHoogland
I agree with capitalizing both letters, but, regardless of what convention
we use (both capitalized or not), there should be a convention. Currently, this
PR, that has a focus on fixing word casing inconsistencies, is doing the
opposite, by changing some instances of `Id` to `ID` and leaving others as they
are. Either all instances of the word in this PR should be `ID` or all should
be `Id`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
