JoaoJandre commented on code in PR #9270:
URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1719814697
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##########
@@ -574,6 +580,11 @@ public VolumeInfo createVolumeFromSnapshot(Volume volume,
Snapshot snapshot, Use
throw e;
}
+ boolean kvmIncrementalSnapshot =
SnapshotManager.kvmIncrementalSnapshot.valueIn(_hostDao.findClusterIdByVolumeInfo(snapInfo.getBaseVolume()));
+ if (kvmIncrementalSnapshot &&
DataStoreRole.Image.equals(dataStoreRole)) {
+ snapInfo = snapshotHelper.convertSnapshotIfNeeded(snapInfo);
Review Comment:
No, we have no way of converting existing snapshots from non-incremental
(AKA full) to incremental snapshots. This will only convert incremental
snapshots to full ones in order to create volumes from it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
