JoaoJandre commented on code in PR #9543:
URL: https://github.com/apache/cloudstack/pull/9543#discussion_r1723680167
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/storage/UpdateStoragePoolCmd.java:
##########
@@ -147,7 +147,22 @@ public void setUrl(String url) {
@Override
public void execute() {
- StoragePool result = _storageService.updateStoragePool(this);
+ StoragePool result = null;
+ if (name != null ||
+ (tags != null && !tags.isEmpty()) ||
+ capacityIops != null ||
+ capacityBytes != null ||
+ (details != null && !details.isEmpty()) ||
+ url != null ||
+ isTagARule != null) {
Review Comment:
We could use ObjectUtils.anyNotNull() for all non collection variables and
CollectionUtils.isNotEmpty() for details and tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
