JoaoJandre commented on code in PR #9546:
URL: https://github.com/apache/cloudstack/pull/9546#discussion_r1723774550
##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -3913,8 +3915,7 @@ private Pair<List<Long>, Integer>
searchForServiceOfferingIdsAndCount(ListServic
}
serviceOfferingSearch.join("diskOfferingSearch",
diskOfferingSearch, JoinBuilder.JoinType.INNER, JoinBuilder.JoinCondition.AND,
- serviceOfferingSearch.entity().getDiskOfferingId(),
diskOfferingSearch.entity().getId(),
- serviceOfferingSearch.entity().setString("Active"),
diskOfferingSearch.entity().getState());
+ serviceOfferingSearch.entity().getDiskOfferingId(),
diskOfferingSearch.entity().getId());
Review Comment:
This method is too long (500+ lines...) for me to judge what it is exactly
doing and where it is being done.
I just want to make sure that when creating VMs we don't list inactive
offerings. If this change does not cause that, then I'm ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
