sureshanaparti commented on code in PR #9567:
URL: https://github.com/apache/cloudstack/pull/9567#discussion_r1727470844
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -1314,6 +1316,18 @@ protected String validateConfigurationValue(final String
name, String value, fin
}
}
+ if (type.equals(String.class)) {
+ if
(name.equalsIgnoreCase(SecStorageAllowedInternalDownloadSites.key()) &&
StringUtils.isNotEmpty(value)) {
+ final String[] cidrs = value.split(",");
+ for (final String cidr : cidrs) {
+ if (!NetUtils.isValidIp4(cidr) &&
!NetUtils.isValidIp6(cidr) && !NetUtils.getCleanIp4Cidr(cidr).equals(cidr)) {
+ s_logger.error(String.format("Invalid CIDR %s value
specified for the config value %s", cidr, name));
Review Comment:
```suggestion
s_logger.error(String.format("Invalid CIDR %s value
specified for the config %s", cidr, name));
```
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -1314,6 +1316,18 @@ protected String validateConfigurationValue(final String
name, String value, fin
}
}
+ if (type.equals(String.class)) {
+ if
(name.equalsIgnoreCase(SecStorageAllowedInternalDownloadSites.key()) &&
StringUtils.isNotEmpty(value)) {
+ final String[] cidrs = value.split(",");
+ for (final String cidr : cidrs) {
+ if (!NetUtils.isValidIp4(cidr) &&
!NetUtils.isValidIp6(cidr) && !NetUtils.getCleanIp4Cidr(cidr).equals(cidr)) {
+ s_logger.error(String.format("Invalid CIDR %s value
specified for the config value %s", cidr, name));
+ throw new
InvalidParameterValueException(String.format("Invalid CIDR %s value specified
for the config value %s", cidr, name));
Review Comment:
```suggestion
throw new
InvalidParameterValueException(String.format("Invalid CIDR %s value specified
for the config %s", cidr, name));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
