JoaoJandre commented on PR #9107: URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2305311036
Hey @winterhazel I did some testing, overall it looks good, but I've found one case that I think we should address in this PR. | Number | Config | Value | Result | | --- | --- | --- | --- | | 1 | storage.cleanup.interval | oasij | Error | | 2 | storage.cleanup.interval | . | Error | | 3 | storage.cleanup.interval | ( | Error | | 4 | storage.cleanup.interval | 102938120381209381203981239128 | Error | | 5 | storage.cleanup.interval | | Error | | 6 | storage.cleanup.interval | "" | Error | | 7 | storage.cleanup.interval | 86400 | Ok | | 8 | cpu.overprovisioning.factor | a | Error | | 9 | cpu.overprovisioning.factor | ^ | Error | | 10 | cpu.overprovisioning.factor | 1.1.1 | Error | | 11 | cpu.overprovisioning.factor | 10928091283012830123810293 | OK | | 12 | cpu.overprovisioning.factor | 9999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999 | OK, but this should not be | | 13 | admin.is.allowed.to.deploy.anywhere | 1 | Error | | 14 | admin.is.allowed.to.deploy.anywhere | 0 | Error | | 15 | admin.is.allowed.to.deploy.anywhere | a | Error | | 16 | admin.is.allowed.to.deploy.anywhere | FALSE | Error | | 17 | admin.is.allowed.to.deploy.anywhere | TRUE | Error | | 18 | admin.is.allowed.to.deploy.anywhere | true | OK | | 19 | admin.is.allowed.to.deploy.anywhere | false | OK | Test 12 was sucessful, but the number informed is bigger than the maximum value of Floats and Doubles. Double.parseDouble() returns Infinity if the number being parsed would overflow. We should not allow this config value, we should return an error, like what is done in test 4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
