sureshanaparti commented on code in PR #9543:
URL: https://github.com/apache/cloudstack/pull/9543#discussion_r1732107570
##########
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##########
@@ -1127,8 +1127,10 @@ private Map<String, String> extractApiParamAsMap(Map ds)
{
return details;
}
+ @Override
@ActionEvent(eventType = EventTypes.EVENT_DISABLE_PRIMARY_STORAGE,
eventDescription = "disable storage pool")
- private void disablePrimaryStoragePool(StoragePoolVO primaryStorage) {
+ public StoragePool disablePrimaryStoragePool(Long id) {
+ StoragePoolVO primaryStorage = _storagePoolDao.findById(id);
if (!primaryStorage.getStatus().equals(StoragePoolStatus.Up)) {
Review Comment:
@harikrishna-patnala might result in NPE on enable/disable for removed
pools, it is checked in update storage pool flow earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
