JoaoJandre commented on code in PR #9270:
URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1734551188
##########
server/src/main/java/org/apache/cloudstack/snapshot/SnapshotHelper.java:
##########
@@ -264,4 +264,12 @@ protected Set<Long>
getSnapshotIdsOnlyInPrimaryStorage(long volumeId) {
return snapshotIdsOnlyInPrimaryStorage;
}
+
+ public SnapshotInfo convertSnapshotIfNeeded(SnapshotInfo snapshotInfo) {
+ if (snapshotInfo.getParent() == null ||
!HypervisorType.KVM.equals(snapshotInfo.getHypervisorType())) {
+ return snapshotInfo;
+ }
+
+ return snapshotService.convertSnapshot(snapshotInfo);
Review Comment:
What test did you make to get this result? I'll take a look at it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
