shwstppr commented on PR #9518: URL: https://github.com/apache/cloudstack/pull/9518#issuecomment-2320304162
> clgtm, question about long term maintenance; this will only work for known types of connection pools due to the `createDataSource()` implementation (and nothing else), right? @DaanHoogland yes. Currently, only DBCP2 and HikariCP are the supported connection pooling libraries. Earlier, only DBCP2 was used but now HikariCP is the default and the users can change it back to DBCP2 (setting db.<cloud/cloud_usage/simulator>.connectionPoolLib=dbcp) using `db.properties` if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
