slavkap commented on code in PR #9270:
URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1740689799
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##########
@@ -159,6 +178,49 @@ public class KVMStorageProcessor implements
StorageProcessor {
*/
private long waitDelayForVirshCommands = 1000l;
+ private int incrementalSnapshotTimeout;
+
+ private static final String CHECKPOINT_XML_TEMP_DIR =
"/tmp/cloudstack/checkpointXMLs";
+
+ private static final String BACKUP_XML_TEMP_DIR =
"/tmp/cloudstack/backupXMLs";
+
+ private static final String BACKUP_BEGIN_COMMAND = "virsh backup-begin
--domain %s --backupxml %s --checkpointxml %s";
+
+ private static final String BACKUP_XML = "<domainbackup><disks><disk
name='%s' type='file'><target file='%s'/><driver
type='qcow2'/></disk></disks></domainbackup>";
+
+ private static final String INCREMENTAL_BACKUP_XML =
"<domainbackup><incremental>%s</incremental><disks><disk name='%s'
type='file'><target file='%s'/><driver
type='qcow2'/></disk></disks></domainbackup>";
+
+ private static final String CHECKPOINT_XML =
"<domaincheckpoint><name>%s</name><disks><disk name='%s'
checkpoint='bitmap'/></disks></domaincheckpoint>";
+
+ private static final String CHECKPOINT_DUMP_XML_COMMAND = "virsh
checkpoint-dumpxml --domain %s --checkpointname %s --no-domain";
+
+ private static final String DOMJOBINFO_COMPLETED_COMMAND = "virsh
domjobinfo --domain %s --completed";
+
+ private static final String DOMJOBABORT_COMMAND = "virsh domjobabort
--domain %s";
+
+ private static String CHECKPOINT_DELETE_COMMAND = "virsh checkpoint-delete
--domain %s --checkpointname %s";
+
+ private static final String DUMMY_VM_XML = "<domain type='qemu'>\n" +
Review Comment:
@JoaoJandre, I'm using Rocky Linux 8.9 with libvirt version 8.0 and qemu 6.2.
When I try to take a snapshot on a stopped VM I've got
`error: Cannot check QEMU binary /usr/bin/qemu-system-x86_64: No such file
or directory`
I made a copy of `usr/libexec/qemu-kvm` to the `/usr/bin/qemu-system-x86_64`
and after another try I've got this
`error: unsupported configuration: Emulator '/usr/bin/qemu-system-x86_64'
does not support machine type 'pc-i440fx-2.9'`
probably for machine type you should set something universal or none and for
the emulator to set the right path depending on the distro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
