rohityadavcloud commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1743132012
##########
agent/src/main/java/com/cloud/agent/Agent.java:
##########
@@ -504,6 +504,13 @@ protected void setupStartupCommand(final StartupCommand
startup) {
startup.setGuid(getResourceGuid());
startup.setResourceName(getResourceName());
startup.setVersion(getVersion());
+ startup.setArch(getAgentArch());
+ }
+
+ protected String getAgentArch() {
+ final Script command = new Script("/usr/bin/arch", 500, logger);
Review Comment:
Thanks, this LGTM, but on second though the virsh node info returns the arch
- perhaps instead of forking out a shell process - we can simply query via
libvirt connection?
```
> virsh nodeinfo
CPU model: x86_64
...
# on rpi5:
rohit@cloudpi:~$ virsh nodeinfo
CPU model: aarch64
CPU(s): 4
CPU socket(s): 1
Core(s) per socket: 4
Thread(s) per core: 1
NUMA cell(s): 1
Memory size: 8132920 KiB
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
