vishesh92 commented on code in PR #9628:
URL: https://github.com/apache/cloudstack/pull/9628#discussion_r1743483427


##########
ui/public/locales/en.json:
##########
@@ -3285,6 +3285,7 @@
 "message.set.default.nic": "Please confirm that you would like to make this 
NIC the default for this Instance.",
 "message.set.default.nic.manual": "Please manually update the default NIC on 
the Instance now.",
 "message.setting.updated": "Setting Updated:",
+"message.setting.update.delay": "The new value will take effect within 30 
seconds.",

Review Comment:
   @shwstppr Since we are invalidating the cache, do we need this message?



##########
ui/public/locales/en.json:
##########
@@ -3285,6 +3285,7 @@
 "message.set.default.nic": "Please confirm that you would like to make this 
NIC the default for this Instance.",
 "message.set.default.nic.manual": "Please manually update the default NIC on 
the Instance now.",
 "message.setting.updated": "Setting Updated:",
+"message.setting.update.delay": "The new value will take effect within 30 
seconds.",

Review Comment:
   @shwstppr Since we are invalidating the cache, do we need this message or 
the other UI changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to