weizhouapache commented on code in PR #9518:
URL: https://github.com/apache/cloudstack/pull/9518#discussion_r1743687797
##########
framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java:
##########
@@ -1267,6 +1362,44 @@ private static GenericObjectPoolConfig
createPoolConfig(Integer maxActive, Integ
return config;
}
+ private static DataSource getDefaultDataSource(final String
connectionPoolLib, final String database) {
+ LOGGER.debug("Creating default datasource for database: {} with
connection pool lib: {}",
+ database, connectionPoolLib);
+ if (CONNECTION_POOL_LIB_DBCP.equals(connectionPoolLib)) {
Review Comment:
equalsIgnoreCase ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
