weizhouapache commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2329183051
great, thanks @kiranchavala ! > LGTM , tested manually both static and dynamic routing and works fine without any issues > > Test Case Execution Result > Admin should be able to create ipv4 subnet Pass > Admin should be able to allocate a ipv4subnet to a account or a domain Pass > Admin user should be able to delete a ipv4subnet for the zone Pass > Admin user should be able to list the ipv4subnets for the zone Pass > Admin user should be able to releaseipv4subnet for a zone Pass > Admin user should be able to update the ipv4subnet for a zone Pass > Admin user should be able to create a AS range for a zone Pass > Admin user should be able to delete AS range associated with the zone Pass > Admin user should be able to add BGP peer for a zone Pass > Admin user should be able to update the BGP peer for a zone Pass > Admin user should be able to dedicate the BGP peer for a account or a domain Pass > Admin user should be able to release the dedicated BGP peer for a account or a domain Pass > Admin user should be able to delete the bgppeer associated with a zone Pass > Test the global setting routed.ipv4.network.cidr.auto.allocation.enabled"" Pass > Test the global settings routed.ipv4.network.max.cidr.size and routed.ipv4.network.min.cidr.size Pass > Test the global setting routed.ipv4.vpc.max.cidr.size" and "routed.ipv4.vpc.min.cidr.size"" Pass > Test the global settings use.system.bgp.peers"" Pass > Admin should be able to create network offering with Routed Network mode and static Routing mode Pass > Admin should be able to create network offering with Routed Network mode and Dynamic Routing mode Pass > Admin should be able to create vpc offering with Routed Network mode and static Routing mode Pass > Admin should be able to create vpc offering with Routed Network mode and dynamic Routing mode Pass > Admin/Normal user should be able to create Isolated network with Routed mode network offering which has static Routing mode Pass > Admin/Normal user should be able to create vpc network with Routed mode network offering which has static Routing mode Pass > Admin/Normal user should be able to create Isolated network with Routed mode network offering which has dynamic Routing mode Pass > Admin/Normal user should be able to create vpc network with Routed mode network offering which has dynamic Routing mode Pass > Admin/Normal user should be able to launch a cks cluster in isolated network cretead from Routed mode network offering which has dynamic Routing mode Pass > Admin/User should be able to launch VNF appliance in a network which is created from Routed mode network offering which has dynamic Routing mode Pass > From project view admin should be able to add ipv4subnet, AS number and bgppeers Pass > Admin should be able to change the bpg peer for a isolated network and vpc network Pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org