vishesh92 commented on code in PR #9566:
URL: https://github.com/apache/cloudstack/pull/9566#discussion_r1749900404
##########
server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java:
##########
@@ -730,24 +732,31 @@ public Pair<List<? extends NetworkACLItem>, Integer>
listNetworkACLItems(final L
final SearchCriteria<NetworkACLItemVO> sc = sb.create();
- if (id != null) {
- sc.setParameters("id", id);
- }
+ if (StringUtils.isNotBlank(keyword)) {
+ final SearchCriteria<NetworkACLItemVO> ssc =
_networkACLItemDao.createSearchCriteria();
+ ssc.addOr("protocol", SearchCriteria.Op.LIKE, "%" + keyword + "%");
+ ssc.addOr("reason", SearchCriteria.Op.LIKE, "%" + keyword + "%");
+ sc.addAnd("acl_id", SearchCriteria.Op.SC, ssc);
+ } else {
Review Comment:
@DaanHoogland do we need an else here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
