gpordeus opened a new pull request, #9735: URL: https://github.com/apache/cloudstack/pull/9735
### Description The MS sends the destroy/delete command of a VM to vCenter when cleaning up its volumes. If the VM does not have a root volume, the VM with its folder and metadata files remain in vCenter. To reproduce, deploy a VM, detach its volume, and delete the VM. Then, check vCenter and the VM will still be there. This PR fixes it by implementing finalizeExpunge for VMWareGuru, which queues a Cleanup Command that, if the VM still exists, sends a destroy command to vCenter to cleanup whatever remained. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [X] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? | Deploy VM | Destroy VM | Before PR | After PR | | ------ | ------ | ------ | ------ | | Without data disks, detach root disk. | With expunge | VM remains on vCenter :x: | VM gone from vCenter :white_check_mark: | | Without data disks, detach root disk. | Without expunge | VM remains on vCenter :white_check_mark: | VM remains on vCenter :white_check_mark: | | Without data disks, detach nothing | With expunge | VM gone from vCenter :white_check_mark: | VM gone from vCenter :white_check_mark: | | With a data disk, detach root disk | With expunge, without selecting data disk | VM remains on vCenter :x: | VM gone from vCenter :white_check_mark: | | With a data disk, detach root disk | With expunge, selecting the data disk | VM remains on vCenter :x: | VM gone from vCenter :white_check_mark: | | With a data disk, detach nothing | With expunge, without selecting the data disk | VM gone from vCenter :white_check_mark: | VM gone from vCenter :white_check_mark: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
