weizhouapache commented on code in PR #9741:
URL: https://github.com/apache/cloudstack/pull/9741#discussion_r1778621562
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java:
##########
@@ -70,6 +71,9 @@ public class UpdateAccountCmd extends BaseCmd {
@Parameter(name = ApiConstants.ACCOUNT_DETAILS, type = CommandType.MAP,
description = "Details for the account used to store specific parameters")
private Map details;
+ @Parameter(name = ApiConstants.API_KEY_ACCESS, type = CommandType.STRING,
description = "Determines if Api key access for this user is enabled, disabled
or inherits the value from its parent, the domain level setting
\"api.key.access\"", since = "4.20.1.0", authorized = {RoleType.Admin})
Review Comment:
is it targetted 4.20.1 ?
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -955,6 +955,11 @@ public Configuration updateConfiguration(final
UpdateCfgCmd cmd) throws InvalidP
category = config.getCategory();
}
+ if ("System".equals(category) &&
!_accountMgr.isRootAdmin(caller.getId())) {
Review Comment:
maybe define a constant "System" somewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
