winterhazel commented on code in PR #7081:
URL: https://github.com/apache/cloudstack/pull/7081#discussion_r1811007783
##########
systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py:
##########
@@ -339,6 +339,9 @@ def to_str(self, delete=False):
printable = printable.replace('!_-', '! -')
if delete:
printable = printable.replace('-A', '-D')
+ if k == "--save-mark":
Review Comment:
Hi Wei,
I talked with Rodrigo, and he said that this change was made to fix an error
when deleting port forwarding rules where the VR couldn't find the correct rule
to delete. We couldn't figure out the exact situation that resulted in this
error though.
From what I've tested so far, this change does not seem necessary (at least
anymore). Maybe the problem that caused the error got fixed in another PR.
Therefore, I'm going to remove these lines, finish adjusting this PR and do
some extensive testing. If it really does not seem to affect anything, I'll
leave the PR without these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
