shwstppr opened a new pull request, #9840:
URL: https://github.com/apache/cloudstack/pull/9840
### Description
Following changes and improvements have been added:
- Improvements in handling of PingRoutingCommand
1. Added global config - `vm.sync.power.state.transitioning`, default
value: true, to control syncing of power states for transitioning VMs. This can
be set to false to prevent computation of transitioning state VMs.
2. Improved VirtualMachinePowerStateSync to allow power state sync for
host VMs in a batch
3. Optimized scanning stalled VMs
- Added option to set worker threads for capacity calculation using config -
`capacity.calculate.workers`
- Added caching framework based on Caffeine in-memory caching library,
https://github.com/ben-manes/caffeine
- Added caching for account/use role API access with expiration after write
can be configured using config - `dynamic.apichecker.cache.period`. If set to
zero then there will be no caching. Default is 0.
- Added caching for account/use role API access with expiration after write
set to 60 seconds.
- Added caching for some recurring DB retrievals
1. CapacityManager - listing service offerings - beneficial in host
capacity calculation
2. LibvirtServerDiscoverer existing host for the cluster - beneficial
for host joins
3. DownloadListener - hypervisors for zone - beneficial for host joins
5. VirtualMachineManagerImpl - VMs in progress- beneficial for
processing stalled VMs during PingRoutingCommands
- Optimized MS list retrieval for agent connect
- Optimize finding ready systemvm template for zone
- Database retrieval optimisations - fix and refactor for cases where only
IDs or counts are used mainly for hosts and other infra entities. Also similar
cases for VMs and other entities related to host concerning background tasks
- Changes in agent-agentmanager connection with NIO client-server classes
1. Optimized the use of the executor service
2. Refactore Agent class to better handle connections.
3. Do SSL handshakes within worker threads
5. Added global configs to control the behaviour depending on the infra.
SSL handshake could be a bottleneck during agent connections. Configs -
`agent.ssl.handshake.min.workers` and `agent.ssl.handshake.max.workers` can be
used to control number of new connections management server handles at a time.
`agent.ssl.handshake.timeout` can be used to set number of seconds after which
SSL handshake times out at MS end.
6. On agent side backoff and sslhandshake timeout can be controlled by
agent properties. `backoff.seconds` and `ssl.handshake.timeout` properties can
be used.
- Improvements in StatsCollection - minimize DB retrievals.
- Improvements in DeploymentPlanner allow for the retrieval of only desired
host fields and fewer retrievals.
- Improvements in hosts connection for a storage pool. Added config -
`storage.pool.host.connect.workers` to control the number of worker threads
that can be used to connect hosts to a storage pool. Worker thread approach is
followed currently only for NFS and ScaleIO pools.
- Minor improvements in resource limit calculations wrt DB retrievals
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
