vishesh92 commented on PR #8756: URL: https://github.com/apache/cloudstack/pull/8756#issuecomment-2436986431
> > Cluster drs plan response change will also require a change here: > > > > https://github.com/apache/cloudstack/blob/019f2c60ceb7a7c15c670a98280bd5764a5fcf5b/test/integration/smoke/test_cluster_drs.py#L181-L183 > > > > BTW, we can also use the fields from the BaseResponse class in ClusterDrsPlanMigrationResponse and don't need to rename the current responses in that case. > > @vishesh92 > actually we do not need to change the variable names (from jobId to migrationJobId), but the serializeName must be changed (ApiConstants.JOB_ID -> ApiConstants.MIGRATION_JOB_ID). > in another word, the changes with UI and smoke test are required. Yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
