shwstppr commented on code in PR #9840:
URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828890475
##########
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##########
@@ -1540,6 +1545,77 @@ protected String
getStoragePoolNonDestroyedVolumesLog(long storagePoolId) {
return sb.toString();
}
+ protected void cleanupConnectedHostConnectionForFailedStorage(DataStore
primaryStore, List<Long> poolHostIds) {
+ for (Long hostId : poolHostIds) {
+ try {
+ disconnectHostFromSharedPool(hostId, primaryStore.getId());
+ } catch (StorageUnavailableException | StorageConflictException e)
{
+ logger.error("Error during cleaning up failed storage host
connection", e);
+ }
+ }
+ }
+
+ @Override
+ public void connectHostsToPool(DataStore primaryStore, List<Long> hostIds,
Scope scope,
+ boolean handleExceptionsPartially, boolean errorOnNoUpHost)
throws CloudRuntimeException {
Review Comment:
Added check
##########
server/src/main/java/org/apache/cloudstack/acl/RoleManagerImpl.java:
##########
@@ -594,7 +594,7 @@ public String getConfigComponentName() {
@Override
public ConfigKey<?>[] getConfigKeys() {
- return new ConfigKey<?>[] {RoleService.EnableDynamicApiChecker};
+ return new ConfigKey<?>[] {RoleService.EnableDynamicApiChecker,
RoleService.DynamicApiCheckerCachePeriod};
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
