shwstppr commented on PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#issuecomment-2469787830
Thank you @harikrishna-patnala for the review @GutoVeronezi thank you for the feedback and suggestion. I agree with the rationale of smaller PRs but I would request you and others to consider this as an exception. The work in this PR is a part of larger scalability work which I'll also be presenting at CCC. In this PR, the focus is mainly on persistence layer and infrastructure entities. There are also some changes wrt schema and other areas which were quick fixes and yield performance improvements. I'll be adding more details after the conference, including some benchmarking tests and unit tests. If you've reservations around a particular set of changes or module, I can try creating a separate diff for that and discuss creating a separate PR around that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org