DaanHoogland commented on code in PR #9500:
URL: https://github.com/apache/cloudstack/pull/9500#discussion_r1848155355
##########
framework/quota/src/main/java/org/apache/cloudstack/quota/activationrule/presetvariables/PresetVariableHelper.java:
##########
@@ -389,12 +431,16 @@ protected String getPresetVariableValueOsName(Long
guestOsId) {
return guestOsVo.getDisplayName();
}
- protected ComputeOffering
getPresetVariableValueComputeOffering(ServiceOfferingVO serviceOfferingVo) {
+ protected ComputeOffering
getPresetVariableValueComputeOffering(ServiceOfferingVO serviceOfferingVo, int
usageType) {
ComputeOffering computeOffering = new ComputeOffering();
computeOffering.setId(serviceOfferingVo.getUuid());
computeOffering.setName(serviceOfferingVo.getName());
computeOffering.setCustomized(serviceOfferingVo.isDynamic());
+ if (usageType == UsageTypes.RUNNING_VM) {
Review Comment:
about time we change this to an enum. (no critique on this PR intended!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
