Pearl1594 commented on code in PR #10000: URL: https://github.com/apache/cloudstack/pull/10000#discussion_r1863491062
########## ui/src/views/infra/UsageRecords.vue: ########## @@ -70,7 +72,7 @@ </a-card> </a-affix> <a-col> - <a-card size="small" :loading="serverMetricsLoading"> + <a-card size="small" :loading="serverMetricsLoading" v-if="'listUsageServerMetrics' in this.$store.getters.apis"> Review Comment: ```suggestion <a-card size="small" :loading="serverMetricsLoading" v-if="'listUsageServerMetrics' in $store.getters.apis"> ``` ########## ui/src/views/infra/UsageRecords.vue: ########## @@ -50,6 +50,7 @@ <a-row justify="end"> <a-col> <tooltip-button + v-if="'generateUsageRecords' in this.$store.getters.apis" Review Comment: minor nit: there's no need to use `this` here ```suggestion v-if="'generateUsageRecords' in $store.getters.apis" ``` ########## ui/src/views/infra/UsageRecords.vue: ########## @@ -159,7 +161,7 @@ /> </a-form-item> </a-col> - <a-col :span="3"> + <a-col :span="3" v-if="'listUsageTypes' in this.$store.getters.apis"> Review Comment: ```suggestion <a-col :span="3" v-if="'listUsageTypes' in $store.getters.apis"> ``` ########## ui/src/views/infra/UsageRecords.vue: ########## @@ -58,6 +59,7 @@ </a-col> <a-col> <tooltip-button + v-if="'removeRawUsageRecords' in this.$store.getters.apis" Review Comment: same here ```suggestion v-if="'removeRawUsageRecords' in $store.getters.apis" ``` ########## ui/src/views/infra/UsageRecords.vue: ########## @@ -173,7 +175,7 @@ /> </a-form-item> </a-col> - <a-col :span="3"> + <a-col :span="3" v-if="'listUsageTypes' in this.$store.getters.apis"> Review Comment: ```suggestion <a-col :span="3" v-if="'listUsageTypes' in $store.getters.apis"> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org